feat: Add prev pageview duration #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
robbie-c
commented
Aug 9, 2024
| } | ||
|
|
||
| private _previousScrollProperties(): PageViewEventProperties { | ||
| private _previousPageViewProperties(timestamp: Date): PageViewEventProperties { |
There was a problem hiding this comment.
Probably easier to view this diff without whitespace changes
|
Size Change: +648 B (+0.06%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
daibhin
approved these changes
Aug 9, 2024
This was referenced Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add prev pageview duration, for a customer, inspired by this slack thread https://posthog.slack.com/archives/C05LJK1N3CP/p1723144788366199
We already do have some logic for measuring the time between the same event (that gets stored in storage rather than in memory), but that doesn't add e.g. pageview duration to a pageleave event, and doesn't match up with the other prev_pageview props like prev_pageview_pathname, which the paths view on web analytics already uses.
Checklist